Genesys Backend issueshttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues2019-05-15T23:56:17+02:00https://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/445Request API: remove request2019-05-15T23:56:17+02:00Matija ObrezaRequest API: remove requestRequest database contains records that are duplicates or test requests. Please add `remove` endpoint to Request API, only for ADMIN accounts.Request database contains records that are duplicates or test requests. Please add `remove` endpoint to Request API, only for ADMIN accounts.2.4Viacheslav PavlovViacheslav Pavlovhttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/444ACCENAME in AccessionData2019-05-21T09:38:33+02:00Matija ObrezaACCENAME in AccessionDataDifferent names of an accession are stored as `AccessionAlias` and one accession has a list of them.
See if we can add `getAccessionName` that returns the first alias of type `ACCENAME`. This, in theory, should force lazy loading the a...Different names of an accession are stored as `AccessionAlias` and one accession has a list of them.
See if we can add `getAccessionName` that returns the first alias of type `ACCENAME`. This, in theory, should force lazy loading the aliases list. But we don't need to change the database.
I think in the past we misused the `getAccessionName` to return `accessionNumber`. If we have any EL expressions in JSP that use `accessionName` they should be modified to `accessionNumber`.2.4Viacheslav PavlovViacheslav Pavlovhttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/358Linking subsets and datasets with accessions2018-10-09T15:48:06+02:00Matija ObrezaLinking subsets and datasets with accessionsDataset currently uses a list of `AccessionIdentifier` records to specify which accessions (by instcode, accenumb, genus **or** doi) are referenced in the dataset.
Subset, on the other hand, uses a list of `AccessionId` so that even if ...Dataset currently uses a list of `AccessionIdentifier` records to specify which accessions (by instcode, accenumb, genus **or** doi) are referenced in the dataset.
Subset, on the other hand, uses a list of `AccessionId` so that even if the accession is deleted from Genesys (and is removed from `Accession` and added to `AccessionHistoric`) the subset still maintains the reference to the original record. This was a good idea originally, but it fails in the case where an accession is **reuploaded** to Genesys -- Subset will not link to the correct record anymore.
## Properly referencing accessions
- Rename and move `org.genesys.catalog.model.dataset.AccessionIdentifier` to `org.genesys2.server.model.genesys.AccessionRef`.
- Change `private AccessionId accession` to `private Accession accession`
- We can now use `AccessionFilter` in `DatasetFilter`!
### Serialization
Serialize property `accession` of `AccessionRef` as `@JsonUnwrapped`. This will embed all key data from `Accession` into this object (hope that works).
### AspectJ
- When an accession is **deleted** from `Accession` (table `accession`) the code should update all `AccessionRef#accession` to `null`.
- When an accession is **saved** to `Accession` (table `accession`) the code should update `AccessionRef#accession` where a match is found.
## Subset update
Replace `private List<AccessionId> accessions` with `private List<AccessionRef> accessions`.
This allows us to have Subsets that "reference" an accession that does not have passport data in Genesys, but it will in the future. It also allows users to delete an accession (rarely) and re-upload it to the system.
## Liquibase
- ~~Rename `inverseJoinColumns = @JoinColumn(name = "acce_id")` to `a_id`.~~
- Migrate all existing data2.4Viacheslav PavlovViacheslav Pavlovhttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/280Bug: CWR page 5002018-08-27T10:06:08+02:00Matija ObrezaBug: CWR page 500- Go to the https://sandbox.genesys-pgr.org/welcome
- Click on the CWR Project link;
## Overviews
The page is fixed in 78739c47, but the overviews do not show up. Fix the overviews.- Go to the https://sandbox.genesys-pgr.org/welcome
- Click on the CWR Project link;
## Overviews
The page is fixed in 78739c47, but the overviews do not show up. Fix the overviews.2.4Matija ObrezaMatija Obreza