Genesys Backend issueshttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues2017-09-19T13:31:08+02:00https://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/118Ability to save a list with an existing title2017-09-19T13:31:08+02:00Aleksandr KirichenkoAbility to save a list with an existing title**Steps:**
1. Go to "https://sandbox.genesys-pgr.org/welcome";
2. Click "Browse" menu item;
3. Mark check-boxes of some accessions;
4. Click "My List" menu item;
5. Navigate to "Accession List" tab;
6. Enter an existing Title list;
7. C...**Steps:**
1. Go to "https://sandbox.genesys-pgr.org/welcome";
2. Click "Browse" menu item;
3. Mark check-boxes of some accessions;
4. Click "My List" menu item;
5. Navigate to "Accession List" tab;
6. Enter an existing Title list;
7. Click "CREATE NEW LIST" button;
**Act.res.:** List of accessions has been saved with an existing title.
![SCR_0022](/uploads/5c9ff4a6f876838359becbcfa96e394d/SCR_0022.png)2.1Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/117Ability to save list of accessions without List title.2017-09-19T13:31:08+02:00Aleksandr KirichenkoAbility to save list of accessions without List title.**Steps:**
1. Go to "https://sandbox.genesys-pgr.org/welcome";
2. Click "Browse" menu item;
3. Mark check-boxes of some accessions;
4. Click "My List" menu item;
5. Navigate to "Accession List" tab;
6. Leave fields "List title", "List d...**Steps:**
1. Go to "https://sandbox.genesys-pgr.org/welcome";
2. Click "Browse" menu item;
3. Mark check-boxes of some accessions;
4. Click "My List" menu item;
5. Navigate to "Accession List" tab;
6. Leave fields "List title", "List description" blank;
7. Click "CREATE NEW LIST" button;
**Act.res.:** The list has been saved without List title and description. See attached screen.![SCR_0021](/uploads/4f1cd9c04c43b8029af4a1f2a0b2aeae/SCR_0021.png)2.1Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/116When user goes to the next page, the page doesn't scroll up.2017-09-19T13:31:08+02:00Aleksandr KirichenkoWhen user goes to the next page, the page doesn't scroll up.**Steps:**
1. Go to "https://sandbox.genesys-pgr.org/welcome";
2. Click "Browse" menu item;
3. Scroll to the bottom of the page;
4. Click on the ">" next page button;
**Exp.res.:**Transfer to the next page is performed, the page is in t...**Steps:**
1. Go to "https://sandbox.genesys-pgr.org/welcome";
2. Click "Browse" menu item;
3. Scroll to the bottom of the page;
4. Click on the ">" next page button;
**Exp.res.:**Transfer to the next page is performed, the page is in the position starting from the top of the table of accessions.
**Act.res.:** Transfer to the next page is performed, page is not scrolled up. See attached video.[rec_011.avi](/uploads/9e6f3ff14c47d224db59474225535108/rec_011.avi)2.1Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/115"About Genesys" drop-down menu is constantly opens when user navigate to any ...2017-09-19T13:31:08+02:00Aleksandr Kirichenko"About Genesys" drop-down menu is constantly opens when user navigate to any page from this menu.**Steps:**
1. Go to "https://sandbox.genesys-pgr.org/welcome";
2. Click "About Genesys" drop-down menu;
3. Select any page from the drop-down, "Contact Us" for example;
**It works only when page zoom = 100%!**
**Act.res.:** "About Ge...**Steps:**
1. Go to "https://sandbox.genesys-pgr.org/welcome";
2. Click "About Genesys" drop-down menu;
3. Select any page from the drop-down, "Contact Us" for example;
**It works only when page zoom = 100%!**
**Act.res.:** "About Genesys" drop-down menu is opened. See attached video[rec_010.avi](/uploads/28e452cadd4b4fca4804e74dd52fdd31/rec_010.avi)2.1Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/114Asciidoc missing images2017-09-19T13:31:08+02:00Matija ObrezaAsciidoc missing imageshttps://www.genesys-pgr.org/doc/0/basics is missing images (e.g. https://www.genesys-pgr.org/doc/0/images/wiews-archived.png)
These should be copied as part of the build process, but are not included on production/sandbox environment.https://www.genesys-pgr.org/doc/0/basics is missing images (e.g. https://www.genesys-pgr.org/doc/0/images/wiews-archived.png)
These should be copied as part of the build process, but are not included on production/sandbox environment.2.1Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/109DOI as accession URL2017-09-19T13:31:08+02:00Matija ObrezaDOI as accession URLThis is one of the subtasks for #56. Depends on #106.
For accessions with a DOI registered in Genesys, we will use the following URL template: `https://www.genesys-pgr.org/[DOI]` for example `https://www.genesys-pgr.org/10.18730/A3C9`. ...This is one of the subtasks for #56. Depends on #106.
For accessions with a DOI registered in Genesys, we will use the following URL template: `https://www.genesys-pgr.org/[DOI]` for example `https://www.genesys-pgr.org/10.18730/A3C9`. Every URL to an accession with DOI must use the DOI'zed URL.
DOI format regexp is `10\.[0-9]+/.+`.
# DOI Controller
Add a controller for DOI resolution at `/{doi:10\.[0-9]+/.+}`. The DOI can identify various objects in Genesys. It should check if an
accession with the DOI exists and display accession details if an accession has such DOI.
## Accession Controller
The current controller (for `/acn/id/[0-9]+`) must permanently redirect to the DOI'zed accession URL in Genesys if the accession record has the DOI assigned.
# DOI as URL
When the accession has DOI assigned, all links to accession details must point to the DOI'zed accession URL and not the `/acn/id/*`.
The URL is now *generated* in JSP directly, perhaps we should have a method to create the accession URL?2.1Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/106Add DOI field2017-09-19T13:31:08+02:00Matija ObrezaAdd DOI fieldThis is one of the subtasks for #56.
Add a **unique** DOI field (`doi varchar(255) null`) to the accession record. Accession historic should also have the field, but it should not have the unique constraint. Make sure database changes a...This is one of the subtasks for #56.
Add a **unique** DOI field (`doi varchar(255) null`) to the accession record. Accession historic should also have the field, but it should not have the unique constraint. Make sure database changes are registered in liquibase changelog.
Further:
1. Extend the `AccessionJSON` with the `doi` field so the field gets indexed.
1. Add display of DOI field to the accession details
1. Add display of DOI field to the accession explorer
1. Add DOI as filter (exact filter) to the accession filters2.1Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/153donorName size2017-09-19T13:39:36+02:00Matija ObrezadonorName sizeMake sensible update for `donorName`.
```
Data truncation: Data too long for column 'donorName'
```Make sensible update for `donorName`.
```
Data truncation: Data too long for column 'donorName'
```2.1Matija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/151Improve MVC logging2017-09-19T14:31:45+02:00Matija ObrezaImprove MVC loggingLogs are polluted with stack trace for unsupported request method:
```
22:35:39,545 qtp1876631416-646 ERROR o.g.s.s.c.UserControllerAdvice - Request method 'GET' not supported
org.springframework.web.HttpRequestMethodNotSupportedExcepti...Logs are polluted with stack trace for unsupported request method:
```
22:35:39,545 qtp1876631416-646 ERROR o.g.s.s.c.UserControllerAdvice - Request method 'GET' not supported
org.springframework.web.HttpRequestMethodNotSupportedException: Request method 'GET' not supported
at org.springframework.web.servlet.mvc.method.RequestMappingInfoHandlerMapping.handleNoMatch(RequestMappingInfoHandlerMapping.java:207)
at org.springframework.web.servlet.handler.AbstractHandlerMethodMapping.lookupHandlerMethod(AbstractHandlerMethodMapping.java:374)
at org.springframework.web.servlet.handler.AbstractHandlerMethodMapping.getHandlerInternal(AbstractHandlerMethodMapping.java:314)
...
```
Improve log output by printing the message:
```
Request method {} not supported for URL {}
```2.1Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/78Creating new lists of accessions impossible for USER2017-09-19T14:55:38+02:00Aleksandr KirichenkoCreating new lists of accessions impossible for USER@mobreza, @ncastaneda Could you give some explanation, who can create the list of accessions? It's Administrator, or it doesn't matter..? Logically it looks like any logged user can do it. But as I see now it's impossible for simple regi...@mobreza, @ncastaneda Could you give some explanation, who can create the list of accessions? It's Administrator, or it doesn't matter..? Logically it looks like any logged user can do it. But as I see now it's impossible for simple registered user. Is it wrong behaviour, or it's ok?![Saved_lists_of_accessions](/uploads/3efb1eddcd665b7283c48aa35062aceb/Saved_lists_of_accessions.png)![403_-_Access_denied](/uploads/3608d14926b96110e8f29abe4f7c004d/403_-_Access_denied.png)2.1Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/124Question about "Allow others to access the list" functionality.2017-09-19T16:23:22+02:00Aleksandr KirichenkoQuestion about "Allow others to access the list" functionality.@mobreza Could you please provide some description about "Allow others to access the list" functionality. I suppose this functionality connected with "Team" and should be removed as well, am I right?
![SCR_0025](/uploads/1230c803288556b...@mobreza Could you please provide some description about "Allow others to access the list" functionality. I suppose this functionality connected with "Team" and should be removed as well, am I right?
![SCR_0025](/uploads/1230c803288556b28015a7d7549bae6c/SCR_0025.png)Matija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/157Sci names in My List2017-09-19T20:14:08+02:00Matija ObrezaSci names in My ListScientific names are not rendered appropriately: See rendering in the Browser (make sure to select Scientific name in the list of displayed columns).Scientific names are not rendered appropriately: See rendering in the Browser (make sure to select Scientific name in the list of displayed columns).2.1Nina Tkachenkon.tkachenko@aimprosoft.comNina Tkachenkon.tkachenko@aimprosoft.comhttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/150Loggers admin failure2017-09-19T20:14:09+02:00Matija ObrezaLoggers admin failureTrying to adjust log levels in Admin pages does not work, it appends a `.` to the listed logger name and that fails to set the new log level of the selected logger.Trying to adjust log levels in Admin pages does not work, it appends a `.` to the listed logger name and that fails to set the new log level of the selected logger.2.1Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/152Jumpy dropdown menu2017-09-20T15:43:27+02:00Matija ObrezaJumpy dropdown menuOn https://sandbox.genesys-pgr.org/welcome open the "About Genesys" dropdown menu.
Hover over and out of "Last updates of passport data" and observe the change in dropdown menu width.On https://sandbox.genesys-pgr.org/welcome open the "About Genesys" dropdown menu.
Hover over and out of "Last updates of passport data" and observe the change in dropdown menu width.2.1Svetlana AlieksieievaSvetlana Alieksieievahttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/108DOI in export2017-09-20T20:33:14+02:00Matija ObrezaDOI in exportThis is one of the subtasks for #56. Depends on #106.
Include **doi** field in CSV and Excel exports.This is one of the subtasks for #56. Depends on #106.
Include **doi** field in CSV and Excel exports.2.1Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/154Release 2.12017-09-20T21:03:52+02:00Matija ObrezaRelease 2.1Release version **2.1**Release version **2.1**2.1Matija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/159MaxPageLimitException log2017-09-22T11:41:04+02:00Matija ObrezaMaxPageLimitException log`MaxPageLimitException` clutters the log with the entire stack trace:
```
org.genesys2.server.exception.MaxPageLimitException: Genesys does not support requests for data beyond 500th page.
```
For this type of exception, print only the...`MaxPageLimitException` clutters the log with the entire stack trace:
```
org.genesys2.server.exception.MaxPageLimitException: Genesys does not support requests for data beyond 500th page.
```
For this type of exception, print only the message:
```
Genesys does not support requests for data beyond 500th page. Requested page was XXXX.
```2.2Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/160"Results per page" functionality - incorrect behavior2017-09-22T11:41:04+02:00Aleksandr Kirichenko"Results per page" functionality - incorrect behavior**Steps:**
1. Go to "Browse" page "https://sandbox.genesys-pgr.org/explore";
2. Change "Results per page" value on "10" option e.g.;
3. Change number of displayed columns and click apply button;
Act.res.: "Results per page" value turns...**Steps:**
1. Go to "Browse" page "https://sandbox.genesys-pgr.org/explore";
2. Change "Results per page" value on "10" option e.g.;
3. Change number of displayed columns and click apply button;
Act.res.: "Results per page" value turns to option "50";
See attached video:
![recording_0001](/uploads/db8196303be959f4b11a5bd54c6bbc21/recording_0001.gif)2.2Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/158Error /data/view/3892017-09-22T13:29:03+02:00Matija ObrezaError /data/view/389```
org.apache.jasper.JasperException: An exception occurred processing JSP page /WEB-INF/jsp/metadata/view.jsp at line 127
124: <tr class="acn ${status.count % 2 == 0 ? 'even' : 'odd'}">
125: <td class="idx-col"><c:out value="...```
org.apache.jasper.JasperException: An exception occurred processing JSP page /WEB-INF/jsp/metadata/view.jsp at line 127
124: <tr class="acn ${status.count % 2 == 0 ? 'even' : 'odd'}">
125: <td class="idx-col"><c:out value="${status.count + pagedData.size * pagedData.number}" /></td>
126: <td class="sel" x-aid="${accession.id}"></td>
127: <td><local:accession-details-link accession="${accession}" /></td>
128: <%-- <td><a href="<c:url value="/geo/${accession.origin}" />"><c:out value="${accession.countryOfOrigin.getName(pageContext.response.locale)}" /></a></td>
129: --%>
130: <td><span dir="ltr" class="sci-name"><c:out escapeXml="false" value="${accession.taxonomy.taxonNameHtml}" /></span></td>
```Matija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/156FTP password2017-09-22T16:33:46+02:00Matija ObrezaFTP passwordAdd property `ftpPassword` to Genesys user.
In user profile page, for roles **ADMINISTRATOR** and **VETTED_USER** display button "Generate FTP password". Upon clicking the button, a random password is generated, the hash of the password...Add property `ftpPassword` to Genesys user.
In user profile page, for roles **ADMINISTRATOR** and **VETTED_USER** display button "Generate FTP password". Upon clicking the button, a random password is generated, the hash of the password is saved to `ftpPassword` and the plain text password is shown one time to the user:
```
Your FTP credentials are:
Username: user's-email
Password: generated-password
```
The new password must pass current PasswordPolicy.
If user has a non-blank `ftpPassword`, her user profile must display the message:
```
Your FTP credentials are:
Username: user's-email
Password: *
```
(Just display the *)2.2Maxym BorodenkoMaxym Borodenko