Skip to content

GitLab

Closed
Created by Matija Obreza@mobrezaOwner

Filters conversion

Filtering by DEU as "Country of holding institute" calls: https://sandbox.genesys-pgr.org/explore/listFilterSuggestions?filter=%7B%22institute.country.iso3%22%3A%5B%22DEU%22%5D%7D

The conversion of the old filter (AppliedFilters) fails with Unknown base institute.country:

2018-09-25T08:12:20.605602345Z Caused by: java.lang.RuntimeException: Unknown base institute.country
2018-09-25T08:12:20.605609064Z 	at org.genesys2.server.service.filter.AppliedFiltersConverter.convert(AppliedFiltersConverter.java:168)
2018-09-25T08:12:20.605616054Z 	at org.genesys2.server.service.filter.AccessionFilter.convert(AccessionFilter.java:166)
2018-09-25T08:12:20.605623037Z 	... 116 more

The same happens for original filters names regionHoldInst and regionOrigin.

Updates

Please extend CountryFilter with support for Set<Long> regionId and update AppliedFiltersConverter.convert to convert:

  • regionHoldInst to holder.country.regionId
  • regionOrigin to origin.regionId

Please add StringFilter alias to AccessionFilter. It should check if accession.accessionId.aliases.any().name matches the filter.

Edited by Matija Obreza