Genesys Website issueshttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues2019-02-27T08:18:42+01:00https://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/232Subset: accessionRefs not updated correctly2019-02-27T08:18:42+01:00Matija ObrezaSubset: accessionRefs not updated correctlyNavigating between different Subsets in the Dashboard does not update the accessionRefs properly.Navigating between different Subsets in the Dashboard does not update the accessionRefs properly.0.1https://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/231Subset: accession list2019-02-25T11:01:24+01:00Matija ObrezaSubset: accession listInfinite loader on https://beta.genesys-pgr.org/subsets/f0f203b2-7e26-4804-94f5-ac4869a34c26 jumps to top when loading next batch.Infinite loader on https://beta.genesys-pgr.org/subsets/f0f203b2-7e26-4804-94f5-ac4869a34c26 jumps to top when loading next batch.0.1Viacheslav PavlovViacheslav Pavlovhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/230Link to future climate layers2019-02-21T15:27:23+01:00Nora Castaneda-AlvarezLink to future climate layersLink to this url: http://ccafs-climate.org/Link to this url: http://ccafs-climate.org/Matija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/229Embed Banana diversity tree2019-06-09T01:28:12+02:00Peter GiovanniniEmbed Banana diversity tree@pgiovannini1 prepares the mock up (include title , description , list of contributors)
We will begin with [Banana Tree](https://gitlab.croptrust.org/genesys-pgr/diversity-tree-editor/blob/master/trees/banana_tree.json)
Other trees in ...@pgiovannini1 prepares the mock up (include title , description , list of contributors)
We will begin with [Banana Tree](https://gitlab.croptrust.org/genesys-pgr/diversity-tree-editor/blob/master/trees/banana_tree.json)
Other trees in JSON are at https://gitlab.croptrust.org/genesys-pgr/diversity-tree-editor/tree/master/trees.
Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/228Add infinite loading to Select descriptors step2019-02-25T10:13:53+01:00Viacheslav PavlovAdd infinite loading to Select descriptors stepPlease add infinite loading to Dataset "Traits" step and Descriptor list's "Select descriptor" step.
![image](/uploads/8613956ea38e6897317a9633ac06d5ba/image.png)
Descriptors paged can be stored at `state.datasets.dashboard.descriptors...Please add infinite loading to Dataset "Traits" step and Descriptor list's "Select descriptor" step.
![image](/uploads/8613956ea38e6897317a9633ac06d5ba/image.png)
Descriptors paged can be stored at `state.datasets.dashboard.descriptors` as we do with `accessionRefs`
Also please delete unused `pagination` from those components:
```ts
pagination: new Pagination<DescriptorFilter>({
page: +parse(ownProps.location.search).p || 0, // current page
size: +parse(ownProps.location.search).l || 20, // page size
sort: parse(ownProps.location.search).s, // page sorts
dir: parse(ownProps.location.search).d, // page sort directions
}),
```Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/227DescriptorList: DisplayPage2019-02-20T18:37:52+01:00Matija ObrezaDescriptorList: DisplayPageIn https://gitlab.croptrust.org/genesys-pgr/genesys-server/commit/f6566b5460b46074433c06697a4184d8ff8c0132 I've included the `terms` of all descriptors in a descriptor list.
This results in terms being rendered, but not properly styled:...In https://gitlab.croptrust.org/genesys-pgr/genesys-server/commit/f6566b5460b46074433c06697a4184d8ff8c0132 I've included the `terms` of all descriptors in a descriptor list.
This results in terms being rendered, but not properly styled:
![image](/uploads/823f8b35dbeb424bca732dca20d8b8a4/image.png)
## Update `DescriptorCard`
- When `CODED` render terms
- When `SCALE` render scale
- When `NUMERIC` include `uom`.
![image](/uploads/f970164532f95ac9f31deecc7526b8ed/image.png)
All already components exist and must be reused.0.1Matija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/226PrettyFilters in Dashboard2019-02-25T17:45:59+01:00Matija ObrezaPrettyFilters in DashboardWe apparently don't use `PrettyFilters` in the Dashboard and Admin pages. How did that happen?
Please add `<PrettyFilters` to Dashboard and Admin browse pages.We apparently don't use `PrettyFilters` in the Dashboard and Admin pages. How did that happen?
Please add `<PrettyFilters` to Dashboard and Admin browse pages.0.1Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/225Send request second step leads to the 401 error2019-02-22T10:10:18+01:00Aleksandr KirichenkoSend request second step leads to the 401 errorIf unauthorized user go to the second step "Personal information" of the "Requesting material from holding institutes" form it leads to the 401 error
Steps:
1. Go to the Accession browser "https://sandbox.genesys-pgr.org/a";
2. Add at ...If unauthorized user go to the second step "Personal information" of the "Requesting material from holding institutes" form it leads to the 401 error
Steps:
1. Go to the Accession browser "https://sandbox.genesys-pgr.org/a";
2. Add at least one accession to the list;
3. Go to the "My list" page;
4. Click on the "Send request" button
5. On the "/requests/create" page click on the "Next step" button.
See attached screen:
![recording_0016](/uploads/616281647c15923f3d9ea99f0d8d2abd/recording_0016.gif)
@mobreza If I understand correctly, the system expects thet user to be authorized at this step. It would probably be better if an unauthorized user is redirected to the login page after click on the Next step button? Or is it possible for any user to create request by filling unregistered email in the second step?Andrey GarnitskiyAndrey Garnitskiyhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/224Extending Leaflet maps2019-02-21T16:03:14+01:00Matija ObrezaExtending Leaflet mapsInstead of using our sidebar, can we make use of https://leafletjs.com/examples/layers-control/ or even better, the https://leafletjs.com/examples/extending/extending-3-controls.html to render our custom buttons and layer selection contr...Instead of using our sidebar, can we make use of https://leafletjs.com/examples/layers-control/ or even better, the https://leafletjs.com/examples/extending/extending-3-controls.html to render our custom buttons and layer selection controls?0.1Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/223Map selected accessions2019-05-31T10:23:34+02:00Aleksandr KirichenkoMap selected accessions"Show Accession Map" functionality on the "My list" page to show Selected accessions on the map is missing. Please implement the map as a "tab":
![image](/uploads/f2f8bf321ed25aaf59288245998be01d/image.png)
And then display the map the..."Show Accession Map" functionality on the "My list" page to show Selected accessions on the map is missing. Please implement the map as a "tab":
![image](/uploads/f2f8bf321ed25aaf59288245998be01d/image.png)
And then display the map the same way we display institutes for a country:
![image](/uploads/e2845e6906f2dd4330f84391526eb640/image.png)
On click the accession number and link should be displayed:
![image](/uploads/4d09edf9581a2a7a3c2fcdbd417b642a/image.png)
0.1Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/222Accession location map2019-02-21T16:22:37+01:00Matija ObrezaAccession location maphttps://beta.genesys-pgr.org/10.18730/1PG8M does not display map of accession's locality:
```
Uncaught TypeError: Cannot read property '_leaflet_pos' of undefined
at Nt (vendors.2cabd4c9ec54a6658abf.js:1)
at t._getMapPanePos (ve...https://beta.genesys-pgr.org/10.18730/1PG8M does not display map of accession's locality:
```
Uncaught TypeError: Cannot read property '_leaflet_pos' of undefined
at Nt (vendors.2cabd4c9ec54a6658abf.js:1)
at t._getMapPanePos (vendors.2cabd4c9ec54a6658abf.js:1)
at t.containerPointToLayerPoint (vendors.2cabd4c9ec54a6658abf.js:1)
at t.containerPointToLatLng (vendors.2cabd4c9ec54a6658abf.js:1)
at t.setZoomAround (vendors.2cabd4c9ec54a6658abf.js:1)
at t._performZoom (vendors.2cabd4c9ec54a6658abf.js:1)
```0.1Viacheslav PavlovViacheslav Pavlovhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/221All maps with same config2019-02-19T19:37:08+01:00Matija ObrezaAll maps with same configThe user is now able to configure the layers and the settings remain applied (until page reload).
There are other pages where maps are used:
- https://beta.genesys-pgr.org/iso3166/CHE
- https://beta.genesys-pgr.org/wiews/CHE001
- ... o...The user is now able to configure the layers and the settings remain applied (until page reload).
There are other pages where maps are used:
- https://beta.genesys-pgr.org/iso3166/CHE
- https://beta.genesys-pgr.org/wiews/CHE001
- ... otherS?
Please use the same layers and map configuration as the user has set up in the accession maps.0.1Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/220Display number of accessions2019-02-19T19:44:24+01:00Matija ObrezaDisplay number of accessionsPlease move the display of number of matching accessions to the bar with pretty filters:
![image](/uploads/6000cba31f41fadb12a14eba43e20a7f/image.png)
This should also work on Overviews and Maps pages. That requires updating the API ...Please move the display of number of matching accessions to the bar with pretty filters:
![image](/uploads/6000cba31f41fadb12a14eba43e20a7f/image.png)
This should also work on Overviews and Maps pages. That requires updating the API response for overviews to include the accession count. `mapInfo` already contains `{ ... accessionCount: 188574 ... }`.0.1Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/219Applying "Accession number" filter causes an error 5042021-02-15T10:23:16+01:00Aleksandr KirichenkoApplying "Accession number" filter causes an error 504@mobreza This is not a 100% reproducible problem, but it is quite common and I think it requires attention.
Steps:
1. Go to the "https://sandbox.genesys-pgr.org/a";
2. Input valid accession number in the "Accession number" input field;
...@mobreza This is not a 100% reproducible problem, but it is quite common and I think it requires attention.
Steps:
1. Go to the "https://sandbox.genesys-pgr.org/a";
2. Input valid accession number in the "Accession number" input field;
3. Click on the "Apply Filters" button.
See attached video:
![recording_0015](/uploads/bae291303182ad5b9496d5a2c6c1074b/recording_0015.gif)
![SCR_00011](/uploads/9ed8b02f540c838592092c076d8fc95d/SCR_00011.png)Vladyslava MokliakVladyslava Mokliakhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/218SID autocompleter delay2019-02-25T13:03:53+01:00Matija ObrezaSID autocompleter delaySID autocomplete in Permission editor fetches data on every key press. This makes it impossible to type in a name.
Add a delay.SID autocomplete in Permission editor fetches data on every key press. This makes it impossible to type in a name.
Add a delay.0.1Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/217Subsets: dashboard2019-02-11T12:53:28+01:00Matija ObrezaSubsets: dashboardWhen Subset is in DRAFT, I cannot edit it. If it is in REVIEW then I can't APPROVE it.When Subset is in DRAFT, I cannot edit it. If it is in REVIEW then I can't APPROVE it.0.1Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/216Handle 4042021-02-15T10:20:24+01:00Matija ObrezaHandle 404https://sandbox.genesys-pgr.org/10.31132/XXXX should result in a 404 page not in
```
Cannot read property 'accessionNumber' of null
```https://sandbox.genesys-pgr.org/10.31132/XXXX should result in a 404 page not in
```
Cannot read property 'accessionNumber' of null
```1.0Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/215Login form. Different buttons height.2019-02-08T10:06:19+01:00Aleksandr KirichenkoLogin form. Different buttons height.**Steps:**
1. Go to the "https://sandbox.genesys-pgr.org/login";
Actual result: "Login" and "login with google" buttons have different height. See attached screen:
![scr_000001](/uploads/5acf1c870cd9331eaaa6c57a3918f000/scr_000001.jpg)**Steps:**
1. Go to the "https://sandbox.genesys-pgr.org/login";
Actual result: "Login" and "login with google" buttons have different height. See attached screen:
![scr_000001](/uploads/5acf1c870cd9331eaaa6c57a3918f000/scr_000001.jpg)Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/214Activity indicator2019-03-07T17:13:20+01:00Matija ObrezaActivity indicatorThe current implementation of the website uses this pattern:
1. Initiate action
1. Show snackbar
1. ...
1. Data received, state updated
1. Show snackbar
In step 3 above, the user has no idea that the application is waiting for a respon...The current implementation of the website uses this pattern:
1. Initiate action
1. Show snackbar
1. ...
1. Data received, state updated
1. Show snackbar
In step 3 above, the user has no idea that the application is waiting for a response or that the operation timed out.
Consider the accession browse page https://beta.genesys-pgr.org/a:
![image](/uploads/d1e7fbb7153bdfbef8b79483db1f1355/image.png)
When the user applies filters the following should happen:
1. Show snackbar
1. Inject the `<Loading />` indicator before the current list of results.
1. The loading indicator should stay visible until new data is received.
If the request fails show a snackbar. Hide the `<Loading /> indicator.
## How do we control for two clicks?
1. We can either wait for the current request to finish
1. or better, cancel the request and start a new one
The second approach is much more user friendly so let's try that. Example for canceling Axios requests at https://github.com/axios/axios/issues/1361
## Demo
Demonstrate this on the accession browse page and we can come up with a solution that will be applied across the entire application.0.1Viacheslav PavlovViacheslav Pavlovhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/213Display accession Data Provider2019-02-11T18:47:54+01:00Matija ObrezaDisplay accession Data ProviderOn the accession display page, add below "Institute code" a new line with:
"Data provider" and display value of `<b>${details.institute.owner.shortName}<b> ${details.institute.owner.fullName}`.
## Update filters
On the Accession brows...On the accession display page, add below "Institute code" a new line with:
"Data provider" and display value of `<b>${details.institute.owner.shortName}<b> ${details.institute.owner.fullName}`.
## Update filters
On the Accession browse page, add filtering on `accession.institute.owner` (similar to what we have in Datasets).
On Institute browse page, add filtering on `institute.owner`.0.1Oleksii SavranOleksii Savran