Genesys Website issueshttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues2019-03-14T18:19:14+01:00https://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/250Bug: removing institute from partner2019-03-14T18:19:14+01:00Matija ObrezaBug: removing institute from partnerTrying to remove an institute when editing existing Partner record results in
```
react-dom.development.js:240 Uncaught TypeError: Cannot read property 'includes' of undefined
at dashboard.ts:48
at Array.filter (<anonymous>)
...Trying to remove an institute when editing existing Partner record results in
```
react-dom.development.js:240 Uncaught TypeError: Cannot read property 'includes' of undefined
at dashboard.ts:48
at Array.filter (<anonymous>)
at partner (dashboard.ts:48)
at combination (redux.js:435)
at combination (redux.js:435)
at dispatch (redux.js:213)
at middleware.js:13
at index.js:11
at dispatch (redux.js:563)
at ApiCall.ts:25
```0.1Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/245Genesys partners2019-03-12T15:28:12+01:00Matija ObrezaGenesys partnersPlease update "Data providers" page https://beta.genesys-pgr.org/partners
1. List data providers in alphabetical order (title)
1. Remove filters
1. infinite load must stay
No changes to backend are required.Please update "Data providers" page https://beta.genesys-pgr.org/partners
1. List data providers in alphabetical order (title)
1. Remove filters
1. infinite load must stay
No changes to backend are required.0.1Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/246Logo underline2019-03-11T12:08:00+01:00Matija ObrezaLogo underlineRemove the custom light-gray underline below Genesys logo (also mobile), use one color below the header bar.
![image](/uploads/7790e3e838d586e2f187160001f8bae2/image.png)
Also on admin and dashboard pages.Remove the custom light-gray underline below Genesys logo (also mobile), use one color below the header bar.
![image](/uploads/7790e3e838d586e2f187160001f8bae2/image.png)
Also on admin and dashboard pages.0.1Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/247Wording2019-03-08T15:08:26+01:00Matija ObrezaWording- ~~Partner~~ &rarr; **Data provider**
- ~~Origin~~ &rarr; **Provenance**
- ~~Order~~ &rarr; **Request**- ~~Partner~~ → **Data provider**
- ~~Origin~~ → **Provenance**
- ~~Order~~ → **Request**0.1Matija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/214Activity indicator2019-03-07T17:13:20+01:00Matija ObrezaActivity indicatorThe current implementation of the website uses this pattern:
1. Initiate action
1. Show snackbar
1. ...
1. Data received, state updated
1. Show snackbar
In step 3 above, the user has no idea that the application is waiting for a respon...The current implementation of the website uses this pattern:
1. Initiate action
1. Show snackbar
1. ...
1. Data received, state updated
1. Show snackbar
In step 3 above, the user has no idea that the application is waiting for a response or that the operation timed out.
Consider the accession browse page https://beta.genesys-pgr.org/a:
![image](/uploads/d1e7fbb7153bdfbef8b79483db1f1355/image.png)
When the user applies filters the following should happen:
1. Show snackbar
1. Inject the `<Loading />` indicator before the current list of results.
1. The loading indicator should stay visible until new data is received.
If the request fails show a snackbar. Hide the `<Loading /> indicator.
## How do we control for two clicks?
1. We can either wait for the current request to finish
1. or better, cancel the request and start a new one
The second approach is much more user friendly so let's try that. Example for canceling Axios requests at https://github.com/axios/axios/issues/1361
## Demo
Demonstrate this on the accession browse page and we can come up with a solution that will be applied across the entire application.0.1Viacheslav PavlovViacheslav Pavlovhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/239Documentation pages styles2019-03-07T13:50:02+01:00Matija ObrezaDocumentation pages stylesUpdate styles for documentation pages (like https://beta.genesys-pgr.org/documentation/apis) to look more like article pages (https://beta.genesys-pgr.org/content/about/about).
Can we ignore the styles coming from asciidoc? Or only take...Update styles for documentation pages (like https://beta.genesys-pgr.org/documentation/apis) to look more like article pages (https://beta.genesys-pgr.org/content/about/about).
Can we ignore the styles coming from asciidoc? Or only take some styles and embed them into our custom `asciidoc.scss` that is `require()` from our component?0.1Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/241Login redirects2019-03-07T12:17:57+01:00Matija ObrezaLogin redirectsAfter any user logs into Genesys they are redirected to `/dashboard`.
- Please make the redirect after login to entry page
- Allow only users with role `VETTEDUSER` (or `ADMINISTRATOR`) access to **Catalog** and **Subsets** routes
- Sh...After any user logs into Genesys they are redirected to `/dashboard`.
- Please make the redirect after login to entry page
- Allow only users with role `VETTEDUSER` (or `ADMINISTRATOR`) access to **Catalog** and **Subsets** routes
- Show menus **Catalog** and **Subsets** only to users with role `VETTEDUSER` (or `ADMINISTRATOR`)0.1Viacheslav PavlovViacheslav Pavlovhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/238News list2019-03-06T19:59:41+01:00Matija ObrezaNews listThere is no mechanism to access the news list in the React page. JSP version https://www.genesys-pgr.org/content/news
Add link to the news list at the bottom of the news section on the welcome page.
We have existing controls to render ...There is no mechanism to access the news list in the React page. JSP version https://www.genesys-pgr.org/content/news
Add link to the news list at the bottom of the news section on the welcome page.
We have existing controls to render news item in the Admin Content pages.
## Updates
1. Sort by `createdDate desc` by default
1. Allow sorting `createdDate asc`, `desc` and `modifiedDate desc`, `asc`0.1Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/185Bulk manage repository metadata for selected folder2019-03-06T19:26:23+01:00Matija ObrezaBulk manage repository metadata for selected folderWhen a folder is selected, allow user to download and upload repositoryfile metadata for the folder (right form):
![image](/uploads/0d792dac941e52b1de9bf97db1cbe12d/image.png)
Logic is implemented for JSP MVC.
- New API *v1* endpoints...When a folder is selected, allow user to download and upload repositoryfile metadata for the folder (right form):
![image](/uploads/0d792dac941e52b1de9bf97db1cbe12d/image.png)
Logic is implemented for JSP MVC.
- New API *v1* endpoints needed0.1Maxym BorodenkoMaxym Borodenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/234Versioned subsets2019-03-05T22:24:26+01:00Matija ObrezaVersioned subsetsgenesys-pgr/genesys-server!364 implements versioning for Subsets as described in genesys-pgr/genesys-server#421.
We'd like to implement *versioned subsets*: subset may be updated by the data provider and (when published) both versions s...genesys-pgr/genesys-server!364 implements versioning for Subsets as described in genesys-pgr/genesys-server#421.
We'd like to implement *versioned subsets*: subset may be updated by the data provider and (when published) both versions should be available through Genesys.
1. Obsolete subsets are not listed by default (API returns only latest subsets) but are accessible via direct URL
1. Obsolete subset must display a message that points to the current version of the subset.
## Todo
1. Dashboard: allow user to "create a new version" of any subset: Add "Create new version" to the button action area in the listing of subsets. API call is at */api/v1/subset/create-new-version* (requires source Subset uuid) and returns the new version
1. Display: If `subset.currentVersion: uuid` exists, please display a message "A new version of this subset is available here" with a link to the current version.0.1Viacheslav PavlovViacheslav Pavlovhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/233Dataset/Subset display page: rematchAccessions2019-03-01T17:11:57+01:00Matija ObrezaDataset/Subset display page: rematchAccessionsAllow administrator to call `rematchAccessions` from the Dataset and Subset display pages. Place button next to "Permissions". Methods already exist in services.Allow administrator to call `rematchAccessions` from the Dataset and Subset display pages. Place button next to "Permissions". Methods already exist in services.0.1Viacheslav PavlovViacheslav Pavlovhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/194Removing filter labels leads to 504 error2019-02-27T08:45:09+01:00Aleksandr KirichenkoRemoving filter labels leads to 504 errorRemoving filter labels above the Accessions list one by one without waiting leads to 504 error.
Steps:
1. Go to the "https://sandbox.genesys-pgr.org/a";
2. Select "Yes" option in the Historic records filter and apply;
3. Enter Instit...Removing filter labels above the Accessions list one by one without waiting leads to 504 error.
Steps:
1. Go to the "https://sandbox.genesys-pgr.org/a";
2. Select "Yes" option in the Historic records filter and apply;
3. Enter Institute code value "BEL084" for example and apply;
4. Enter Accession number "ITC0001" for example and apply;
5. Remove filter labels above the Accessions list one by one without waiting.
Expected result: All filter labels removed, filters are reseted.
Actual result: Page endless pending, error 504 is occurred. See attached video:
![recording_0012](/uploads/7f00534b27d271653c36967d250c3c39/recording_0012.gif)Aleksandr KirichenkoAleksandr Kirichenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/232Subset: accessionRefs not updated correctly2019-02-27T08:18:42+01:00Matija ObrezaSubset: accessionRefs not updated correctlyNavigating between different Subsets in the Dashboard does not update the accessionRefs properly.Navigating between different Subsets in the Dashboard does not update the accessionRefs properly.0.1https://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/226PrettyFilters in Dashboard2019-02-25T17:45:59+01:00Matija ObrezaPrettyFilters in DashboardWe apparently don't use `PrettyFilters` in the Dashboard and Admin pages. How did that happen?
Please add `<PrettyFilters` to Dashboard and Admin browse pages.We apparently don't use `PrettyFilters` in the Dashboard and Admin pages. How did that happen?
Please add `<PrettyFilters` to Dashboard and Admin browse pages.0.1Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/218SID autocompleter delay2019-02-25T13:03:53+01:00Matija ObrezaSID autocompleter delaySID autocomplete in Permission editor fetches data on every key press. This makes it impossible to type in a name.
Add a delay.SID autocomplete in Permission editor fetches data on every key press. This makes it impossible to type in a name.
Add a delay.0.1Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/231Subset: accession list2019-02-25T11:01:24+01:00Matija ObrezaSubset: accession listInfinite loader on https://beta.genesys-pgr.org/subsets/f0f203b2-7e26-4804-94f5-ac4869a34c26 jumps to top when loading next batch.Infinite loader on https://beta.genesys-pgr.org/subsets/f0f203b2-7e26-4804-94f5-ac4869a34c26 jumps to top when loading next batch.0.1Viacheslav PavlovViacheslav Pavlovhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/228Add infinite loading to Select descriptors step2019-02-25T10:13:53+01:00Viacheslav PavlovAdd infinite loading to Select descriptors stepPlease add infinite loading to Dataset "Traits" step and Descriptor list's "Select descriptor" step.
![image](/uploads/8613956ea38e6897317a9633ac06d5ba/image.png)
Descriptors paged can be stored at `state.datasets.dashboard.descriptors...Please add infinite loading to Dataset "Traits" step and Descriptor list's "Select descriptor" step.
![image](/uploads/8613956ea38e6897317a9633ac06d5ba/image.png)
Descriptors paged can be stored at `state.datasets.dashboard.descriptors` as we do with `accessionRefs`
Also please delete unused `pagination` from those components:
```ts
pagination: new Pagination<DescriptorFilter>({
page: +parse(ownProps.location.search).p || 0, // current page
size: +parse(ownProps.location.search).l || 20, // page size
sort: parse(ownProps.location.search).s, // page sorts
dir: parse(ownProps.location.search).d, // page sort directions
}),
```Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/206Forgot password functionality2019-02-23T19:06:10+01:00Aleksandr KirichenkoForgot password functionality"Forgot password" and "Remember me" functionality are missing on the login page.
@mobreza Is this omission or so conceived?"Forgot password" and "Remember me" functionality are missing on the login page.
@mobreza Is this omission or so conceived?Viacheslav PavlovViacheslav Pavlovhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/225Send request second step leads to the 401 error2019-02-22T10:10:18+01:00Aleksandr KirichenkoSend request second step leads to the 401 errorIf unauthorized user go to the second step "Personal information" of the "Requesting material from holding institutes" form it leads to the 401 error
Steps:
1. Go to the Accession browser "https://sandbox.genesys-pgr.org/a";
2. Add at ...If unauthorized user go to the second step "Personal information" of the "Requesting material from holding institutes" form it leads to the 401 error
Steps:
1. Go to the Accession browser "https://sandbox.genesys-pgr.org/a";
2. Add at least one accession to the list;
3. Go to the "My list" page;
4. Click on the "Send request" button
5. On the "/requests/create" page click on the "Next step" button.
See attached screen:
![recording_0016](/uploads/616281647c15923f3d9ea99f0d8d2abd/recording_0016.gif)
@mobreza If I understand correctly, the system expects thet user to be authorized at this step. It would probably be better if an unauthorized user is redirected to the login page after click on the Next step button? Or is it possible for any user to create request by filling unregistered email in the second step?Andrey GarnitskiyAndrey Garnitskiyhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/222Accession location map2019-02-21T16:22:37+01:00Matija ObrezaAccession location maphttps://beta.genesys-pgr.org/10.18730/1PG8M does not display map of accession's locality:
```
Uncaught TypeError: Cannot read property '_leaflet_pos' of undefined
at Nt (vendors.2cabd4c9ec54a6658abf.js:1)
at t._getMapPanePos (ve...https://beta.genesys-pgr.org/10.18730/1PG8M does not display map of accession's locality:
```
Uncaught TypeError: Cannot read property '_leaflet_pos' of undefined
at Nt (vendors.2cabd4c9ec54a6658abf.js:1)
at t._getMapPanePos (vendors.2cabd4c9ec54a6658abf.js:1)
at t.containerPointToLayerPoint (vendors.2cabd4c9ec54a6658abf.js:1)
at t.containerPointToLatLng (vendors.2cabd4c9ec54a6658abf.js:1)
at t.setZoomAround (vendors.2cabd4c9ec54a6658abf.js:1)
at t._performZoom (vendors.2cabd4c9ec54a6658abf.js:1)
```0.1Viacheslav PavlovViacheslav Pavlov