Genesys Website issueshttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues2023-11-13T10:18:41+01:00https://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/898UI: Accession details page2023-11-13T10:18:41+01:00Matija ObrezaUI: Accession details pageThe order of accession data on the details page (e.g. https://www.genesys-pgr.org/10.18730/EYJ~) could be improved by displaying the most relevant information first.
1. Scientific name
1. Crop
1. Biological status of accession
1. Proven...The order of accession data on the details page (e.g. https://www.genesys-pgr.org/10.18730/EYJ~) could be improved by displaying the most relevant information first.
1. Scientific name
1. Crop
1. Biological status of accession
1. Provenance of material
1. Accession number
1. DOI
1. ... remaining data
Consider if it can be reorganized according to "the categories" of MCPD descriptors from your presentation.Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/897Descriptor: find-similar2022-04-20T13:49:53+02:00Matija ObrezaDescriptor: find-similargenesys-pgr/genesys-server!692 changes the API signature of /find-similar endpoint for `Descriptor`.
Please revise and update the `DescriptorService` accordingly.genesys-pgr/genesys-server!692 changes the API signature of /find-similar endpoint for `Descriptor`.
Please revise and update the `DescriptorService` accordingly.2022.3Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/896Error if the user search by "subset" or "dataset" without UUID format.2022-03-30T19:53:26+02:00Juan Carlos Alarcon MaldonadoError if the user search by "subset" or "dataset" without UUID format.I got an error message if I try to search by "Subset" or "Dataset" without UUID format.
![image](/uploads/6810400623dc70b84e5410e3732ea7e4/image.png)
after the error, the page "try" "Loading the data" but without any result.I got an error message if I try to search by "Subset" or "Dataset" without UUID format.
![image](/uploads/6810400623dc70b84e5410e3732ea7e4/image.png)
after the error, the page "try" "Loading the data" but without any result.2022.3Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/895Bug: Clicking on "green dot" in map2022-03-30T19:28:28+02:00Matija ObrezaBug: Clicking on "green dot" in mapWhen I try to click on a green accession dot on https://sandbox.genesys-pgr.org/a/map/v2p07XyPYGe/@7.504089,-64.643555,6z nothing happens.
![image](/uploads/516b2ba90cc27ee50439c95246769716/image.png)
What is the "Will-change memory co...When I try to click on a green accession dot on https://sandbox.genesys-pgr.org/a/map/v2p07XyPYGe/@7.504089,-64.643555,6z nothing happens.
![image](/uploads/516b2ba90cc27ee50439c95246769716/image.png)
What is the "Will-change memory consumption is too high."?
## The problem
```
Uncaught TypeError: e.geo.longitude is null
inFilterBounds https://sandbox.genesys-pgr.org/53.4a31e0e537f06f257031.js:2
clickTimeout https://sandbox.genesys-pgr.org/53.4a31e0e537f06f257031.js:2
setTimeout handler*614/Va/this.handleMouseUp https://sandbox.genesys-pgr.org/53.4a31e0e537f06f257031.js:2
fire https://sandbox.genesys-pgr.org/20.4a31e0e537f06f257031.js:2
_fireDOMEvent https://sandbox.genesys-pgr.org/20.4a31e0e537f06f257031.js:2
_handleDOMEvent https://sandbox.genesys-pgr.org/20.4a31e0e537f06f257031.js:2
r https://sandbox.genesys-pgr.org/20.4a31e0e537f06f257031.js:2
53.4a31e0e537f06f257031.js:2:800385
```2022.3Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/894Show unavailable buttons2022-03-24T11:24:03+01:00Matija ObrezaShow unavailable buttonsAnonymous users don't know that advanced functionalities are available. Prime examples are:
![image](/uploads/6e1900556e7f9fd6dcb6789b7fc831ba/image.png)
Convert these buttons to "Available to registered users only" as we do here:
![i...Anonymous users don't know that advanced functionalities are available. Prime examples are:
![image](/uploads/6e1900556e7f9fd6dcb6789b7fc831ba/image.png)
Convert these buttons to "Available to registered users only" as we do here:
![image](/uploads/5a49213460100253640d7aeabca0f398/image.png)
Please advise if there are other places where we hide buttons from anonymous users, but we should display them2022.3Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/893Images and Thumbnails2022-03-25T16:57:32+01:00Matija ObrezaImages and ThumbnailsThe browser sends `Accept: image/avif,image/webp,*/*` HTTP header when requesting for images.
# UI: Static assets
The UI should use the default `.png/jpg` images when `image/webp` is not specified in the `Accept` header. `.webp` should...The browser sends `Accept: image/avif,image/webp,*/*` HTTP header when requesting for images.
# UI: Static assets
The UI should use the default `.png/jpg` images when `image/webp` is not specified in the `Accept` header. `.webp` should only be used if `image/webp` is listed.
This requires an update to our current code because we now only provide `webp` imagery.
# UI: Dynamic assets
We use `repositoryDownloadUrl(...)` to generate the full URL to the specified `RepositoryImage | RepositoryFile`. `repositoryThumbnailUrl(...)` is to generate the URL for a thumbnail or the full-size image (depending on `width` and `height` parameters).
The generated thumbnail URL is `https://cdn1.genesys-pgr.org/repository/d/_thumbs/bf2/bf213552-dd6b-47a9-9eb8-e0f45c86c102/300x300.jpg
When the `image/webp` is supported by the client, we can just provide a link to the `webp` version of the thumbnail image: `..._thumbs/bf2/bf213552-dd6b-47a9-9eb8-e0f45c86c102/300x300.webp`
API implementation in genesys-pgr/genesys-server!691.2022.3Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/892SSR response status code and redirects2022-03-14T19:21:30+01:00Matija ObrezaSSR response status code and redirectsWe are not handling *https://www.genesys-pgr.org/wiews/DbB25* correctly: it shows 404 HTML, but HTTP status is set to `500`?
Same for *https://www.genesys-pgr.org/descriptors/4*.
## Permanent redirects
Please add the following perman...We are not handling *https://www.genesys-pgr.org/wiews/DbB25* correctly: it shows 404 HTML, but HTTP status is set to `500`?
Same for *https://www.genesys-pgr.org/descriptors/4*.
## Permanent redirects
Please add the following permanent redirects to `server.ts`:
|Request URL|Redirect|Note|
|--|--|--|
|`^\/geo$`|`/iso3166`|Replaced route|
|`^\/geo/([a-z]+)$` (lowercase)|`/iso3166/$1` (uppercase)|Replaced route|
|`^\/iso3166/([a-z]+)$` (lowercase)|`/iso3166/$1` (uppercase)|We require uppercase|
|`^\/wiews/([a-z]+\d+)$` (lowercase)|`/wiews/$1` (uppercase)|We require uppercase|2022.3Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/891BUG: Updating routes2022-03-10T13:06:50+01:00Matija ObrezaBUG: Updating routesRouting problem:
1. Open https://www.genesys-pgr.org/a/v2R2rx3E9zA
1. Click "Overview" observe Overview is loaded
1. Click "Accessions" observe accession list is ok
1. Click one of the accessions
1. Open Developer Tools **Network**
1. C...Routing problem:
1. Open https://www.genesys-pgr.org/a/v2R2rx3E9zA
1. Click "Overview" observe Overview is loaded
1. Click "Accessions" observe accession list is ok
1. Click one of the accessions
1. Open Developer Tools **Network**
1. Click "Browse this species at XXXXXX"
1. Observe that list of accessions is shown and pretty filters display the data as expected
1. **Problem:** the URL does not reflect the `filterCode` in the response of the API call!
1. So the link to "Overview" does not have the latest `filterCode` and doesn't show the same pretty filters2022.2Vladyslava MokliakVladyslava Mokliakhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/890BUG: NPE in accession navigation2022-03-09T06:17:04+01:00Matija ObrezaBUG: NPE in accession navigation1. https://sandbox.genesys-pgr.org/a/images/v2D77q22L2k
1. Map
1. Images
1. Map: NPE
```
TypeError: t is null
m https://sandbox.genesys-pgr.org/10.1030c4f69be1bb342db1.js:2
getTileUrl https://sandbox.genesys-pgr.org/10.1030c4f69...1. https://sandbox.genesys-pgr.org/a/images/v2D77q22L2k
1. Map
1. Images
1. Map: NPE
```
TypeError: t is null
m https://sandbox.genesys-pgr.org/10.1030c4f69be1bb342db1.js:2
getTileUrl https://sandbox.genesys-pgr.org/10.1030c4f69be1bb342db1.js:2
createTile https://sandbox.genesys-pgr.org/10.1030c4f69be1bb342db1.js:
```2022.2Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/889Sync localStorage vars between tabs2022-03-09T14:46:58+01:00Matija ObrezaSync localStorage vars between tabsWe store "My List" accession UUIDs in `localStorage`, but it is not synchronized between tabs.
npm packge `use-persisted-state` can help, but we need to consider updating Redux state `list.public.myList.accessionUuids` as well.We store "My List" accession UUIDs in `localStorage`, but it is not synchronized between tabs.
npm packge `use-persisted-state` can help, but we need to consider updating Redux state `list.public.myList.accessionUuids` as well.2022.2Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/888Bug: Saving institute settings2022-03-04T13:21:16+01:00Matija ObrezaBug: Saving institute settingsWhile working on genesys-pgr/genesys-ui#887 I realized that a POST to http://localhost:8080/api/v2/wiews does not update institute settings. ~~They get cleared~~ The UI needs a refresh to show the same old settings.While working on genesys-pgr/genesys-ui#887 I realized that a POST to http://localhost:8080/api/v2/wiews does not update institute settings. ~~They get cleared~~ The UI needs a refresh to show the same old settings.2022.2Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/887Institute requests.mailto2022-03-04T13:27:00+01:00Matija ObrezaInstitute requests.mailtoThe server supports multiple email addresses in the "requests.to" setting of the institute, but the UI does not allow me to use commas:
![image](/uploads/7b9991d74d1cbf0bc01c711606e2cce6/image.png)The server supports multiple email addresses in the "requests.to" setting of the institute, but the UI does not allow me to use commas:
![image](/uploads/7b9991d74d1cbf0bc01c711606e2cce6/image.png)2022.2Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/886UI: User registration and forgot password pages2022-03-08T18:09:39+01:00Matija ObrezaUI: User registration and forgot password pagesThe pages for account registration, email validation, password reset, etc (https://www.genesys-pgr.org/registration, etc) need to use the "limited width" layout.
The "Account registration" page needs to have "You may also be interested ...The pages for account registration, email validation, password reset, etc (https://www.genesys-pgr.org/registration, etc) need to use the "limited width" layout.
The "Account registration" page needs to have "You may also be interested in" section with a link to reset password.2022.2Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/885SSR sitemaps2022-03-14T19:36:36+01:00Matija ObrezaSSR sitemapsWe now use an axios request + buffering in express to serve `sitemap*xml` from the backend API server. See `sitemap.ts`.
This should use `proxy`.We now use an axios request + buffering in express to serve `sitemap*xml` from the backend API server. See `sitemap.ts`.
This should use `proxy`.2022.3Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/884Sandbox UI2022-03-09T11:13:30+01:00Matija ObrezaSandbox UIWe would like to use slightly different style for Sandbox:
- Gray logo
- "Sandbox" instead of "Genesys" in logo text
- `favicon` also gray
- Breadcrumbs with gray background:
![image](/uploads/0361edb8c77bf8ba3c4da79ddb78cd7f/image.png...We would like to use slightly different style for Sandbox:
- Gray logo
- "Sandbox" instead of "Genesys" in logo text
- `favicon` also gray
- Breadcrumbs with gray background:
![image](/uploads/0361edb8c77bf8ba3c4da79ddb78cd7f/image.png)
SSR support required.2022.2Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/883Map bounds on mobile2022-03-14T06:57:30+01:00Matija ObrezaMap bounds on mobileOn mobile https://www.genesys-pgr.org/a/map/v2GrAb5XjPj does not zoom to the 6 accession.
API does not support bounds calculation when full-text is used (https://www.genesys-pgr.org/a/overview/v2AVQj0a7j8). Can we try to update the ES q...On mobile https://www.genesys-pgr.org/a/map/v2GrAb5XjPj does not zoom to the 6 accession.
API does not support bounds calculation when full-text is used (https://www.genesys-pgr.org/a/overview/v2AVQj0a7j8). Can we try to update the ES query?2022.2Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/882Bug: Clearing filters2022-02-15T17:31:30+01:00Matija ObrezaBug: Clearing filtersAfter a filter is removed the page data is correctly loaded without the filter. Scrolling then triggers the load of next page, but uses the previously set filter.
To reproduce:
- Open https://sandbox.genesys-pgr.org/datasets/v2zwplpWOp...After a filter is removed the page data is correctly loaded without the filter. Scrolling then triggers the load of next page, but uses the previously set filter.
To reproduce:
- Open https://sandbox.genesys-pgr.org/datasets/v2zwplpWOp3, observe a filter on "Created date"
- Remove the filter, observe data is loaded and displayed without "Created date" filter
- Scroll down to trigger next page load
- Observe "Created date" filter is used and it shows up in `PrettyFilters` and filtering component
The same issue is visible in production.2022.2Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/881Loaders for chartjs and leaflet2022-02-18T12:59:28+01:00Matija ObrezaLoaders for chartjs and leafletChartjs and Leaflet libraries should be loaded on the client-side only. Please update components to use the same loading approach as for `d3js`.Chartjs and Leaflet libraries should be loaded on the client-side only. Please update components to use the same loading approach as for `d3js`.2022.2Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/880Stepper heading2022-02-20T08:30:10+01:00Matija ObrezaStepper headingThe repetition of the step title may be confusing for the user, especially when making a request for material:
![image](/uploads/a5a4160f508890f6fa8dc9b12bf73371/image.png)
Please remove the title in the footer. This can be applied to ...The repetition of the step title may be confusing for the user, especially when making a request for material:
![image](/uploads/a5a4160f508890f6fa8dc9b12bf73371/image.png)
Please remove the title in the footer. This can be applied to all Steppers.2022.2Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/879API_URL_INTERNAL2022-02-15T14:54:48+01:00Matija ObrezaAPI_URL_INTERNALSSR rendering makes API calls to the public `API_URL`. Requests go to the main Genesys proxy instead of going directly to the API service that is accessible on the same local network.
Please introduce a `API_URL_INTERNAL` option so that...SSR rendering makes API calls to the public `API_URL`. Requests go to the main Genesys proxy instead of going directly to the API service that is accessible on the same local network.
Please introduce a `API_URL_INTERNAL` option so that server will always use the internal URL (usually on http:// not https://) and the client will always use the public `API_URL`.2022.2Maksym TishchenkoMaksym Tishchenko