GLIS Client issueshttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues2024-03-27T14:20:05+01:00https://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/36Generating SMTA with Easy-SMTA2024-03-27T14:20:05+01:00Matija ObrezaGenerating SMTA with Easy-SMTAEasy-SMTA provides a new endpoint to generate the SMTA document in PDF format for the provided recipient, language and type of SMTA and list of material. This ticket extends `glis-client` with code to call the new service.
The paramete...Easy-SMTA provides a new endpoint to generate the SMTA document in PDF format for the provided recipient, language and type of SMTA and list of material. This ticket extends `glis-client` with code to call the new service.
The parameters will be the same or similar to those for reporting SMTA.
@mmarsella will provide the details about the new endpoint once it is available, and then the implementation can begin.Vladyslava MokliakVladyslava Mokliakhttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/35GLIS URL configuration2023-08-03T14:06:42+02:00Matija ObrezaGLIS URL configurationWe currently append `/glis` to all endpoints. Please update so that `/glis` will be part of the `baseUrl` setting.
The documentation and default `application.properties` value in GGCE and Genesys need upgrade to:
```
# Obsolete
# itpg...We currently append `/glis` to all endpoints. Please update so that `/glis` will be part of the `baseUrl` setting.
The documentation and default `application.properties` value in GGCE and Genesys need upgrade to:
```
# Obsolete
# itpgrfa.glis.basepath=...
# ITPGRFA GLIS URL
itpgrfa.glis.url=https://glis.qa.fao.org/glis/
```
Make sure to trim the trailing `/` so that the code does not produce `.fao.org/glis//xxx` URLs.1.4Artem HrybeniukArtem Hrybeniukhttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/34Bundle classes from common2023-01-21T06:58:05+01:00Matija ObrezaBundle classes from commonBundle classes from `common` module into `resttemplate` jar so that we can avoid a separate dependency.
Or at least `resttemplate` should not depend on `common` automatically if it is not used in code.Bundle classes from `common` module into `resttemplate` jar so that we can avoid a separate dependency.
Or at least `resttemplate` should not depend on `common` automatically if it is not used in code.1.3Artem HrybeniukArtem Hrybeniukhttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/33Upgrade dependencies2022-12-27T09:19:59+01:00Matija ObrezaUpgrade dependenciesUpgrade at least the following:
- com.fasterxml.jackson.core/jackson-databind@2.13.2.2
- com.google.guava/guava@23.2-jre
- org.springframework/spring-beans@5.3.19
- org.springframework/spring-web@5.3.19Upgrade at least the following:
- com.fasterxml.jackson.core/jackson-databind@2.13.2.2
- com.google.guava/guava@23.2-jre
- org.springframework/spring-beans@5.3.19
- org.springframework/spring-web@5.3.191.3Artem HrybeniukArtem Hrybeniukhttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/32Support for Easy-SMTA reporting2023-01-09T07:04:56+01:00Matija ObrezaSupport for Easy-SMTA reportingAdd support for reporting Easy-SMTA.
XML protocol is described in [System_Integration_3.0.pdf](/uploads/7e21f9f948cca9c15fe61850f6d2cd5d/System_Integration_3.0.pdf)Add support for reporting Easy-SMTA.
XML protocol is described in [System_Integration_3.0.pdf](/uploads/7e21f9f948cca9c15fe61850f6d2cd5d/System_Integration_3.0.pdf)1.3Artem HrybeniukArtem Hrybeniukhttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/31addtarget endpoint changed2018-02-07T16:17:02+01:00Matija Obrezaaddtarget endpoint changed@mmarsella generalised the API call addtarget, the one we use to register Genesys links in GLIS. The new entry point is: https://ssl.fao.org/glis/links/addtarget
All the rest stays the same. Can you please update the URL you post the JS...@mmarsella generalised the API call addtarget, the one we use to register Genesys links in GLIS. The new entry point is: https://ssl.fao.org/glis/links/addtarget
All the rest stays the same. Can you please update the URL you post the JSON object to? The old one is still active, so no hurry.1.1Matija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/30Release 1.02017-10-27T01:59:00+02:00Matija ObrezaRelease 1.0Release 1.0Release 1.01.0Matija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/28Rate limitation for GLISAPI now on username2017-10-26T21:13:56+02:00Marco MarsellaRate limitation for GLISAPI now on usernameCiao Matija, as GLIS is running behind a proxy and using X-Forwarded-For does not seem a good idea, I have switched to username-based rate limitation. Again, we can discuss setting higher limits for Genesys or no limit at all. Please not...Ciao Matija, as GLIS is running behind a proxy and using X-Forwarded-For does not seem a good idea, I have switched to username-based rate limitation. Again, we can discuss setting higher limits for Genesys or no limit at all. Please note that going through the FAO firewall and proxy greatly reduces the connection speed anyway...https://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/29Rate limit calls to GLIS2017-10-26T23:54:48+02:00Matija ObrezaRate limit calls to GLISUsing AOP, rate-limit calls to GLIS client.
GLIS API call rate limiting is based on ~~IP address of the client~~ username. All Genesys nodes are limited to 20 API calls/second.
genesys-pgr/glis-client#28Using AOP, rate-limit calls to GLIS client.
GLIS API call rate limiting is based on ~~IP address of the client~~ username. All Genesys nodes are limited to 20 API calls/second.
genesys-pgr/glis-client#28https://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/27Terms constants2017-10-26T21:06:18+02:00Matija ObrezaTerms constantsCan we assume that
```json
[{
"code": "1",
"language": "en",
"term": "Passport data"
}, {
"code": "1.1",
"language": "en",
"term": "Genealogy"
}, {
"code": "1.2",
"language": "en",
"term": "Collection documents"
}, {
"code": "...Can we assume that
```json
[{
"code": "1",
"language": "en",
"term": "Passport data"
}, {
"code": "1.1",
"language": "en",
"term": "Genealogy"
}, {
"code": "1.2",
"language": "en",
"term": "Collection documents"
}, {
"code": "2",
"language": "en",
"term": "Characterization"
}, {
"code": "3",
"language": "en",
"term": "Evaluation"
}, {
"code": "3.1",
"language": "en",
"term": "Chemical analysis"
}, {
"code": "3.2",
"language": "en",
"term": "Abiotic stress"
}, {
"code": "3.3",
"language": "en",
"term": "Biotic stress"
}, {
"code": "3.4",
"language": "en",
"term": "Biochemical markers"
}, {
"code": "3.5",
"language": "en",
"term": "Molecular markers"
}, {
"code": "3.6",
"language": "en",
"term": "Cytological characters"
}, {
"code": "3.7",
"language": "en",
"term": "Genomics"
}, {
"code": "3.8",
"language": "en",
"term": "Phenomics"
}, {
"code": "4",
"language": "en",
"term": "Environments"
}, {
"code": "5",
"language": "en",
"term": "Multimedia"
}]
```
are constants and can be bundled to the clients as:
```java
public static final String TARGET_PASSPORT = "1";
public static final String TARGET_GENEALOGY = "1.1";
...
public static final String TARGET_ENVIRONMENTS = "4";
public static final String TARGET_MULTIMEDIA = "5";
```1.0Marco MarsellaMarco Marsellahttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/26PGRFA record by DOI2019-11-22T10:28:51+01:00Matija ObrezaPGRFA record by DOIIs there a way to access PGRFA record by DOI itself? I now use the search function, but that's very inefficient (and slow).
Is there an API endpoint where one can lookup the DOI information on GLIS **Test** without using the `/glisapi/...Is there a way to access PGRFA record by DOI itself? I now use the search function, but that's very inefficient (and slow).
Is there an API endpoint where one can lookup the DOI information on GLIS **Test** without using the `/glisapi/v1/pgrfas` call?1.1Marco MarsellaMarco Marsellahttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/24JSON-only client2017-10-25T20:43:39+02:00Matija ObrezaJSON-only clientThe XML support in swagger-codegen and swagger-core does not match all needs of the GLIS API.
Remove the XML code and create the JSON-only client required for Genesys.The XML support in swagger-codegen and swagger-core does not match all needs of the GLIS API.
Remove the XML code and create the JSON-only client required for Genesys.1.0Matija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/23Updating target in GLIS2017-10-27T08:45:17+02:00Matija ObrezaUpdating target in GLISWe started receiving DOIs on [sandbox](https://sandbox.genesys-pgr.org). Which API call should Genesys use to update the target URL in GLIS?
Is the `/glis/xml/update` applicable for Genesys - GLIS interaction?We started receiving DOIs on [sandbox](https://sandbox.genesys-pgr.org). Which API call should Genesys use to update the target URL in GLIS?
Is the `/glis/xml/update` applicable for Genesys - GLIS interaction?1.0Matija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/22XML schema validation improved2017-09-22T11:30:23+02:00Marco MarsellaXML schema validation improved[register.xsd](/uploads/8c8a9055094fde5b784be574f25ebf5f/register.xsd)The incoming XML is validated against the XSD and errors found at this stage are now properly reported.[register.xsd](/uploads/8c8a9055094fde5b784be574f25ebf5f/register.xsd)The incoming XML is validated against the XSD and errors found at this stage are now properly reported.Marco MarsellaMarco Marsellahttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/21DOI holder bulk check2017-07-26T01:40:05+02:00Matija ObrezaDOI holder bulk checkGLIS should allow for fetching information on PGRFA holder for a set of DOIs.
Genesys would generally query for 50 DOIs in one call.GLIS should allow for fetching information on PGRFA holder for a set of DOIs.
Genesys would generally query for 50 DOIs in one call.Marco MarsellaMarco Marsellahttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/20rels API test2017-09-22T11:30:23+02:00Matija Obrezarels API testAdd a unit test for the relationships call:
1. Register PGRFA#1
1. Register PGRFA#2 with PGRFA#1 as progenitor (method=acquisition)
1. Test rels of PRGRFA#1Add a unit test for the relationships call:
1. Register PGRFA#1
1. Register PGRFA#2 with PGRFA#1 as progenitor (method=acquisition)
1. Test rels of PRGRFA#1https://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/19PGRFA Transfer2017-09-22T11:30:21+02:00Matija ObrezaPGRFA TransferAdd support for `/glis/xml/transfer` endpoint.Add support for `/glis/xml/transfer` endpoint.Matija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/18Fix terms call documentation2017-07-03T10:25:07+02:00Matija ObrezaFix terms call documentationThe example for `/terms` call is the from the `/rels` endpoint that returns the relationships.
Update the YML with appropriate example.The example for `/terms` call is the from the `/rels` endpoint that returns the relationships.
Update the YML with appropriate example.Matija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/17CORS support in GLIS2017-07-03T08:55:24+02:00Matija ObrezaCORS support in GLISCORS is a key element of any HTTP-based API. Browsers make a preflight request to the server using HTTP OPTIONS method (that doesn't allow for request body):
![GLIS-CORS](/uploads/d17a6c741bdd458a88430d0d7bd65ae7/GLIS-CORS.png)
GLIS sh...CORS is a key element of any HTTP-based API. Browsers make a preflight request to the server using HTTP OPTIONS method (that doesn't allow for request body):
![GLIS-CORS](/uploads/d17a6c741bdd458a88430d0d7bd65ae7/GLIS-CORS.png)
GLIS should respond with a valid CORS response.Marco MarsellaMarco Marsellahttps://gitlab.croptrust.org/genesys-pgr/glis-client/-/issues/16GLIS test account for registrations2017-07-01T15:50:57+02:00Matija ObrezaGLIS test account for registrationsUsername `genesys` does not have "write" permissions to any WIEWS code. I use `cgn` for local testing and that generates a lot of CGN accessions with Cropname "Matija".
Could you give `genesys` account permissions to register PGRFA on ...Username `genesys` does not have "write" permissions to any WIEWS code. I use `cgn` for local testing and that generates a lot of CGN accessions with Cropname "Matija".
Could you give `genesys` account permissions to register PGRFA on `XXX001` WIEWS code instead? This way you can easily remove these data from GLIS with a cron job.Marco MarsellaMarco Marsella