GGCE Web issueshttps://gitlab.croptrust.org/grin-global/grin-global-ui/-/issues2021-04-15T11:12:43+02:00https://gitlab.croptrust.org/grin-global/grin-global-ui/-/issues/226Trait name repeated many times2021-04-15T11:12:43+02:00Ghost UserTrait name repeated many timesWhy does the trait name repeat two or more times in some cases (see image)?
![image](/uploads/da672bfa8f224685dafe14c52d5ca9a3/image.png)
The problem is in `Wheat Collection`.Why does the trait name repeat two or more times in some cases (see image)?
![image](/uploads/da672bfa8f224685dafe14c52d5ca9a3/image.png)
The problem is in `Wheat Collection`.2021.4Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/grin-global/grin-global-ui/-/issues/225InventoryFilter with inventoryNumberPart32021-04-13T14:48:38+02:00Matija ObrezaInventoryFilter with inventoryNumberPart3grin-global/support#47 is requesting to include **Inventory Suffix** in the inventory filters -- just like *Inventory Prefix*.
Please add the new filter component below `inventoryNumberPart2` filter.grin-global/support#47 is requesting to include **Inventory Suffix** in the inventory filters -- just like *Inventory Prefix*.
Please add the new filter component below `inventoryNumberPart2` filter.2021.4Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/grin-global/grin-global-ui/-/issues/224Date formats and controls2021-04-13T16:57:16+02:00Matija ObrezaDate formats and controlsGG-CE database stores dates as `Date` in the database and then uses the `xxxDateCode` field to specify how the value is rendered. The set of `DATE_FORMAT` codes is fixed.
The most common date format is the code for *exact date* `MM/dd/y...GG-CE database stores dates as `Date` in the database and then uses the `xxxDateCode` field to specify how the value is rendered. The set of `DATE_FORMAT` codes is fixed.
The most common date format is the code for *exact date* `MM/dd/yyyy`. Please note that the code itself is not used as for formatting the date value: we use the `title`!
The UI uses `moment` to format the date value to a string using `YYYY-MM-DD`. This formatting is required for date pickers in browsers.
The UI must use valid `DATE_FORMAT` codes when interacting with the API -- and a valid format code is usually selected by the user with `<CVField`.
In a few places in UI code, the date code is specified incorrectly:
```ts
// workspaces/ui-express/src/inventorygroup/ui/AcquisitionPage.tsx
accessionSource.sourceDateCode = 'yyyy-MM-dd';
```
Please check the code and use a constant `DATE_FORMAT_DATE = 'MM/dd/yyyy'`
Also please **delete** `data-default="yyyy-MM-dd"`. It should be provided by the user.
Note: grin-global/support#45 is a result of using an invalid date format code.2021.4Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/grin-global/grin-global-ui/-/issues/223Bug: Adjust Inventory Quantity - not updating2021-05-06T03:23:05+02:00Rizalina SulaboBug: Adjust Inventory Quantity - not updatingHi. The changes in quantity on hand was not updated after saving
![image](/uploads/0376cb9eff742d44a1979d414cce646b/image.png)
## Form uses invalid date format
```
YYYY-MM-DD is not a valid CodeValue of DATE_FORMAT
```Hi. The changes in quantity on hand was not updated after saving
![image](/uploads/0376cb9eff742d44a1979d414cce646b/image.png)
## Form uses invalid date format
```
YYYY-MM-DD is not a valid CodeValue of DATE_FORMAT
```2021.4Matija ObrezaMatija Obrezahttps://gitlab.croptrust.org/grin-global/grin-global-ui/-/issues/222Inventory action form2021-04-16T16:37:42+02:00Matija ObrezaInventory action formWhy: allow user to register a new pending inventory action from the inventory actions tab. The same form is used to also edit an existing `InventoryAction`.
Add the `+` button to the "Actions" tab of `Inventory`. The dialog allows user ...Why: allow user to register a new pending inventory action from the inventory actions tab. The same form is used to also edit an existing `InventoryAction`.
Add the `+` button to the "Actions" tab of `Inventory`. The dialog allows user to select:
- `actionNameCode`
- `quantity` and `quantityUnitCode`
- `method`
- `cooperator`
The form also has an `edit` mode where the fields for `startedDate`, `startedDateCode`, `completedDate` and `completedDateCode` are visible and enabled.
Since we are on the `Inventory` details page, the new action will be associated with the current inventory.2021.4Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/grin-global/grin-global-ui/-/issues/219IMP with managementTypeCode2021-04-08T13:14:07+02:00Matija ObrezaIMP with managementTypeCodegrin-global/grin-global-server!196 adds "Management Type" (property `managementTypeCode: string`, code value of `MANAGEMENT_TYPE`) to the `InventoryMaintenancePolicy`.
Please update the table display to include the the new CV field and ...grin-global/grin-global-server!196 adds "Management Type" (property `managementTypeCode: string`, code value of `MANAGEMENT_TYPE`) to the `InventoryMaintenancePolicy`.
Please update the table display to include the the new CV field and the form.2021.4Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/grin-global/grin-global-ui/-/issues/218Table "In progress" dissapears Inventory actions list page, when user is goin...2021-04-12T12:26:17+02:00Artem DovhopolenkoTable "In progress" dissapears Inventory actions list page, when user is going thorough tabsTable "In progress" dissapears on Inventory actions list page, when user is going thorough tabs![Table_in_progress_dissapears__when_user_is_going_thorough_tabs](/uploads/d6a7980c8c470d302bc574eb82704cf8/Table_in_progress_dissapears__when...Table "In progress" dissapears on Inventory actions list page, when user is going thorough tabs![Table_in_progress_dissapears__when_user_is_going_thorough_tabs](/uploads/d6a7980c8c470d302bc574eb82704cf8/Table_in_progress_dissapears__when_user_is_going_thorough_tabs.mp4)2021.4Viacheslav PavlovViacheslav Pavlovhttps://gitlab.croptrust.org/grin-global/grin-global-ui/-/issues/217Trait data: use `codedName`2021-04-07T08:59:53+02:00Matija ObrezaTrait data: use `codedName`It appears that traits sometimes does not have a `title`. Please update the code to use the trait's `codedName` if `title` is missing.
Trait data error in texcoco-w instance, see image.
![image](https://gitlab.croptrust.org/grin-global...It appears that traits sometimes does not have a `title`. Please update the code to use the trait's `codedName` if `title` is missing.
Trait data error in texcoco-w instance, see image.
![image](https://gitlab.croptrust.org/grin-global/support/uploads/fa7df230ab3221af990058b1fcd01045/image.png)2021.4Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/grin-global/grin-global-ui/-/issues/214Summaries with filtering2021-04-07T09:01:42+02:00Matija ObrezaSummaries with filteringAdd filtering support to the "Inventory summary" and "Accession summary" pages.Add filtering support to the "Inventory summary" and "Accession summary" pages.2021.4Viacheslav PavlovViacheslav Pavlovhttps://gitlab.croptrust.org/grin-global/grin-global-ui/-/issues/213Flag dirty form fields2021-04-07T08:57:36+02:00Matija ObrezaFlag dirty form fieldsMentioned in #211, we could highlight all fields that are `dirty`. `dirty` is the standard FormField "dirty": value is not the same as `initialValues`.
Ideas:
- add `Modified: ` to label on dirty fields
- use different color or add an ...Mentioned in #211, we could highlight all fields that are `dirty`. `dirty` is the standard FormField "dirty": value is not the same as `initialValues`.
Ideas:
- add `Modified: ` to label on dirty fields
- use different color or add an icon
This would probably affect our `<Filter` components too.2021.4Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/grin-global/grin-global-ui/-/issues/212Move "create" forms from routes to dialogs2021-04-16T16:37:42+02:00Matija ObrezaMove "create" forms from routes to dialogsSome of the modules use dedicated routes to render the form to create a new record.
It would be better if creating new records always used the same approach -- the Dialog.
I'm not 100% sure about editing, but it may make sense to rend...Some of the modules use dedicated routes to render the form to create a new record.
It would be better if creating new records always used the same approach -- the Dialog.
I'm not 100% sure about editing, but it may make sense to render the edit form in a dialog, too.2021.4Maksym TishchenkoMaksym Tishchenko