Genesys PGR issueshttps://gitlab.croptrust.org/groups/genesys-pgr/-/issues2024-03-28T10:06:39+01:00https://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/698MaterialSubRequest: Additional states2024-03-28T10:06:39+01:00Artem HrybeniukMaterialSubRequest: Additional statesWe're using the following states:
* `NOTCONFIRMED`: Waiting for the genebank to click the link in the email that they received the request (or used GGCE)
* `CONFIRMED`: Means the genebank clicked the link and they saw the request
* `SEN...We're using the following states:
* `NOTCONFIRMED`: Waiting for the genebank to click the link in the email that they received the request (or used GGCE)
* `CONFIRMED`: Means the genebank clicked the link and they saw the request
* `SENT`: Genebank completed the request
We're missing states:
* `PROCESSING`: The genebank is processing the request.
* `REJECTED`: The genebank rejected the request completely.
Related to https://gitlab.croptrust.org/grin-global/grin-global-ui/-/issues/654.2024.1Artem HrybeniukArtem Hrybeniukhttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/694Editing descriptor in review2024-03-28T10:06:39+01:00Christelle RabilEditing descriptor in reviewYonas reported this message after pressing the edit buttuon on descriptors in review :
>Something went wrong
>
>A bug caused this rapid unscheduled disassembly of Genesys. Please refresh the page and retry your action. If that does not ...Yonas reported this message after pressing the edit buttuon on descriptors in review :
>Something went wrong
>
>A bug caused this rapid unscheduled disassembly of Genesys. Please refresh the page and retry your action. If that does not help, please contact Genesys support and let them know about the problem.
>
>Error: Cannot be un-published. More than 24 hours have passed since the publication.
>URL: https://www.genesys-pgr.org/descriptors/41d610d1-b1ba-4aae-8f1d-da38ee12f37f
(I also tried on my side, and after clearing cache but also same message as above)
cc: @mobreza2024.1Artem HrybeniukArtem Hrybeniukhttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/692Dataset: Check for unmapped descriptors API2024-03-28T10:06:38+01:00Artem HrybeniukDataset: Check for unmapped descriptors APIRelated to https://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/1032.
We need an API endpoint that:
1. Checks which descriptors are mapped for this dataset in Amphibian (gets their `uuid`s)
1. Removes descriptors from the Datas...Related to https://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/1032.
We need an API endpoint that:
1. Checks which descriptors are mapped for this dataset in Amphibian (gets their `uuid`s)
1. Removes descriptors from the Dataset that are not in Amphibian
1. Adds descriptors that are in Amphibian to the Dataset2024.1Artem HrybeniukArtem Hrybeniukhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/1056Upgrade to React 18 and Webpack 52024-03-26T18:12:30+01:00Matija ObrezaUpgrade to React 18 and Webpack 5Upgrade to `react@18` and `webpack@5` similar to grin-global/grin-global-ui#145 and the corresponding grin-global/grin-global-ui!299 in GGCE.Upgrade to `react@18` and `webpack@5` similar to grin-global/grin-global-ui#145 and the corresponding grin-global/grin-global-ui!299 in GGCE.2024.1Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/423Missing translations for pretty filters2024-03-26T07:49:03+01:00Kiril MorhalenkoMissing translations for pretty filtersPlease add translation to pretty filters after apply filters from "EVALUATION SITE" block on the "https://sandbox.genesys-pgr.org/datasets/overview" page.
![image](/uploads/805d226443460ed24ff47f004692f3e2/image.png)Please add translation to pretty filters after apply filters from "EVALUATION SITE" block on the "https://sandbox.genesys-pgr.org/datasets/overview" page.
![image](/uploads/805d226443460ed24ff47f004692f3e2/image.png)Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/418Action buttons under the header of dashboard pages should looks like button bar.2024-03-26T07:49:02+01:00Kiril MorhalenkoAction buttons under the header of dashboard pages should looks like button bar.**Steps:**
1. Go to "https://sandbox.genesys-pgr.org/admin/repository/f/datasets/".
2. Turn on mobile device mode.
**Expected result:**
Framed buttons should have view like button bar.
**Actual result:**
![image](/uploads/0906ff283b07b...**Steps:**
1. Go to "https://sandbox.genesys-pgr.org/admin/repository/f/datasets/".
2. Turn on mobile device mode.
**Expected result:**
Framed buttons should have view like button bar.
**Actual result:**
![image](/uploads/0906ff283b07bb19078a613fe06d2035/image.png)Oleksii SavranOleksii Savranhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/1058Bug: Link accessions silently fails when genus is missing in Dataset2024-03-22T01:13:21+01:00Matija ObrezaBug: Link accessions silently fails when genus is missing in DatasetWhen a default `GENUS` is not specified in Dataset properties and there exists one row where `"genus": ""` then **Link accessions** will report success, but one of the API calls fails with `400 Bad request`. This needs to be reported to ...When a default `GENUS` is not specified in Dataset properties and there exists one row where `"genus": ""` then **Link accessions** will report success, but one of the API calls fails with `400 Bad request`. This needs to be reported to the user instead of silently ignored.2024.1Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/1057Remove duplicate orders2024-03-14T08:40:19+01:00Alejandro VelazquezRemove duplicate ordersWe have received a request in GGCE from Genesys, but we want the cooperator to think that he sent the same thing 5 times.
How can we delete duplicates?
![image](/uploads/74bc7949a3c486ae3b1947abaaed3972/image.png)We have received a request in GGCE from Genesys, but we want the cooperator to think that he sent the same thing 5 times.
How can we delete duplicates?
![image](/uploads/74bc7949a3c486ae3b1947abaaed3972/image.png)https://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/699Reject test DOIs2024-03-11T14:37:42+01:00Matija ObrezaReject test DOIsgrin-global/grin-global-server#464 documents a case were a "test DOI" made it to Genesys and then the "real DOI" couldn't be assigned due to how Genesys treats the DOI.
We need to prevent "test DOIs" in Genesys by throwing an error (pro...grin-global/grin-global-server#464 documents a case were a "test DOI" made it to Genesys and then the "real DOI" couldn't be assigned due to how Genesys treats the DOI.
We need to prevent "test DOIs" in Genesys by throwing an error (probably in `@PrePersist/@PreUpdate`).
@mmarsella says we can safely reject DOIs with prefix 10.0155 (i.e. `/^10\.(?!0155)/`. Further advice on matching `/^10\.[1-9]/` pending.2024.1Artem HrybeniukArtem Hrybeniukhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/1055Admin: disbling OAuth clients2024-03-10T08:52:10+01:00Matija ObrezaAdmin: disbling OAuth clientsUpdate Admin for enabling/disabling OAuth clients Similar to update in grin-global/grin-global-ui!613 + https://gitlab.croptrust.org/grin-global/grin-global-ui/-/commit/8121fa98c5dae0d3c8677c6b48678d5fe5f3343eUpdate Admin for enabling/disabling OAuth clients Similar to update in grin-global/grin-global-ui!613 + https://gitlab.croptrust.org/grin-global/grin-global-ui/-/commit/8121fa98c5dae0d3c8677c6b48678d5fe5f3343e2024.1Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/file-repository/-/issues/45Spotbugs2024-03-05T10:46:04+01:00Matija ObrezaSpotbugsAdd Spotbugs to gradle as in genesys-pgr/application-blocks!147 and fix the obvious problems.Add Spotbugs to gradle as in genesys-pgr/application-blocks!147 and fix the obvious problems.5.2Artem HrybeniukArtem Hrybeniukhttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/1027Webpack 52024-03-04T12:10:17+01:00Matija ObrezaWebpack 5We're ready for `webpack@5` -- the migration was done previously for `ggce-web`, so this should be quite straightforward.We're ready for `webpack@5` -- the migration was done previously for `ggce-web`, so this should be quite straightforward.2023.8Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/1054Starting a request for material fails2024-03-01T06:01:59+01:00Matija ObrezaStarting a request for material failsClicking "Request for material" on https://sandbox.genesys-pgr.org/sel throws a fatal error message.Clicking "Request for material" on https://sandbox.genesys-pgr.org/sel throws a fatal error message.2024.1Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/ui-embedded/-/issues/88Cart: Show number of items2024-02-29T17:30:30+01:00Matija ObrezaCart: Show number of itemsDisplay the number of items in the Cart page:
![image](/uploads/fa163e1d41b20f477750dcaae91cde74/image.png)
I think it might be better if we change the title to say:
- `cart_empty`: No items in your cart
- `cart_item_count`: One item ...Display the number of items in the Cart page:
![image](/uploads/fa163e1d41b20f477750dcaae91cde74/image.png)
I think it might be better if we change the title to say:
- `cart_empty`: No items in your cart
- `cart_item_count`: One item in your cart
- `cart_item_count_plural`: `{{count, number}} items in your cart`1.6Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesysr/-/issues/7genesysr R package error2024-02-23T09:46:26+01:00GitLab Support Botgenesysr R package errorDear Matija,
I am unable to login to Genesys with `genesysr` R package. Running `user_login()` is giving the following error probably due to a change in the depency package `httr2`.
```R
Warning message:
The `host_name` argument of `oa...Dear Matija,
I am unable to login to Genesys with `genesysr` R package. Running `user_login()` is giving the following error probably due to a change in the depency package `httr2`.
```R
Warning message:
The `host_name` argument of `oauth_flow_auth_code()` is deprecated as of httr2 1.0.0.
Please use the `redirect_uri` argument instead.
The deprecated feature was likely used in the httr2 package.
Please report the issue at <https://github.com/r-lib/httr2/issues>.
```
Also it is not possible to report any bug via gitlab as it is crop trust repo.
I hope this is cleared up soon.
Best Regards,
J. Aravind,
Scientist,
Division of Germplasm Conservation
ICAR-National Bureau of Plant Genetic Resources,
New Delhi - 110 012https://gitlab.croptrust.org/genesys-pgr/validator/-/issues/26Results of validator tool of geodata seem to have a bug2024-02-21T10:36:42+01:00Christelle RabilResults of validator tool of geodata seem to have a bugI used the same sample data to demonstrate the validator tool in November, these were the results:
![Screenshot_2024-01-23_at_14-23-32_Passport_data_preparation_-_Part_3_Webinar_series_with_Genesys_-_YouTube](/uploads/b08fc188a7a5ef877...I used the same sample data to demonstrate the validator tool in November, these were the results:
![Screenshot_2024-01-23_at_14-23-32_Passport_data_preparation_-_Part_3_Webinar_series_with_Genesys_-_YouTube](/uploads/b08fc188a7a5ef87750706bd51e37c3c/Screenshot_2024-01-23_at_14-23-32_Passport_data_preparation_-_Part_3_Webinar_series_with_Genesys_-_YouTube.png)
I used the same sample just now and the results show this:
![Screenshot_2024-01-23_at_14-18-27_Passport_data_validation](/uploads/79413c08a2249a3b616741ed63bc86fa/Screenshot_2024-01-23_at_14-18-27_Passport_data_validation.png)
cc: @mobrezaMatija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/genesys-ui/-/issues/1051Institute KPI: Availability for distribution in Show KPI not the same as in t...2024-02-19T19:26:06+01:00Christelle RabilInstitute KPI: Availability for distribution in Show KPI not the same as in the passport data filterFiltering for MEX002 number of available accessions for distribution:
![image](/uploads/b6e406e78b46adc719ddac04e0910a26/image.png)
versus
Number indicated in the MEX002 KPI page:
![image](/uploads/2e6ce85357d41f121a40163deb97dd27/im...Filtering for MEX002 number of available accessions for distribution:
![image](/uploads/b6e406e78b46adc719ddac04e0910a26/image.png)
versus
Number indicated in the MEX002 KPI page:
![image](/uploads/2e6ce85357d41f121a40163deb97dd27/image.png)
I'm not sure but seems to be a bugMatija ObrezaMatija Obrezahttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/696DTO with mapstruct2024-02-19T10:32:42+01:00Matija ObrezaDTO with mapstructIn preparation for Genesys API **v2** please prepare DTO classes for entities and use `mapstruct` to generate mappings from DTO to Entity classes.
Adopt the `FilteredCRUDController2`, `CRUDController2`, `CRUDService2`, etc. from GGCE as...In preparation for Genesys API **v2** please prepare DTO classes for entities and use `mapstruct` to generate mappings from DTO to Entity classes.
Adopt the `FilteredCRUDController2`, `CRUDController2`, `CRUDService2`, etc. from GGCE as the base for API v2.
We will add `*Lang` support to Genesys (genesys-pgr/genesys-server#697) so `Translated...` base classes and interfaces can also be adopted.2024.1Artem HrybeniukArtem Hrybeniukhttps://gitlab.croptrust.org/genesys-pgr/ui-embedded/-/issues/86Bootstrap styles2024-02-16T14:43:47+01:00Matija ObrezaBootstrap stylesAfter dependency upgrades (bootstrap) the forms in the UI are no longer rendering properly: text fields are missing borders and dropdowns have transparent background:
![image](/uploads/a66fd710e5d36f466f9084ebdf811d1a/image.png)
You ca...After dependency upgrades (bootstrap) the forms in the UI are no longer rendering properly: text fields are missing borders and dropdowns have transparent background:
![image](/uploads/a66fd710e5d36f466f9084ebdf811d1a/image.png)
You can compare https://genesys-pgr.p.gitlab.croptrust.org/ui-embedded/edge.html and https://genesys-pgr.p.gitlab.croptrust.org/ui-embedded/ to see the differences.1.6Maksym TishchenkoMaksym Tishchenkohttps://gitlab.croptrust.org/genesys-pgr/genesys-server/-/issues/697Translated entity support2024-02-15T18:48:59+01:00Matija ObrezaTranslated entity supportWe wish to add translation support for `Subset`s and `Dataset`s. Adopt `Translated...` approach from GGCE.We wish to add translation support for `Subset`s and `Dataset`s. Adopt `Translated...` approach from GGCE.2024.1Artem HrybeniukArtem Hrybeniuk