Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Genesys Backend Genesys Backend
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Service Desk
    • Milestones
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Genesys PGRGenesys PGR
  • Genesys BackendGenesys Backend
  • Issues
  • #177
Closed
Open
Issue created Oct 06, 2017 by Matija Obreza@mobrezaOwner

Logging fixed

Using string concatenation "foo=" + bar + " x=" + x" in logging is horribly bad. The SLF4J avoids that by creating the log message string on demand (if current log level must be logged).

Replace ALL loggers with org.slf4j.Logger and make sure they are called LOG:

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

...

Logger LOG = LoggerFactory.getLogger(...

Replace all string concatenation in calls to LOG.info, LOG.debug, etc. with message format logging:

LOG.info("Test value=" + value + " other=" + other);
// must be
LOG.info("Test value={} other={}", value, other);
Assignee
Assign to
Time tracking