Skip to content

GitLab

Genesys Backend
Genesys Backend
Closed
Opened by Matija Obreza@mobrezaOwner

Better exceptions

We are using both org.genesys2.spring.ResourceNotFoundException and the NotFoundElement?Exception. Please consolidate the code so that one of these is used (the NotFound one) because it already uses nice logging.

14:20:51,979 qtp2027961269-14 ERROR o.g.s.a.ApiExceptionHandler:211 - Wow! Such! Exception!
org.genesys2.spring.ResourceNotFoundException
	at org.genesys2.server.service.impl.AccessionServiceImpl.getAccessionDetails(AccessionServiceImpl.java:162)
...
...

Throw InvalidApiUsageException in:

java.lang.RuntimeException: Refusing to export more than 200000 entries
	at org.genesys2.server.mvc.ExplorerController.kml(ExplorerController.java:775)

Check code where it makes sense to replace RuntimeException with InvalidApiUsageException, for example:

java.lang.RuntimeException: Could not render image
	at org.genesys2.server.mvc.ExplorerController.tile(ExplorerController.java:830)
	at org.genesys2.server.mvc.ExplorerController$$FastClassBySpringCGLIB$$827bbdf0.invoke(<generated>)
	at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
Caused by: java.lang.RuntimeException: Could not parse date yyyy-M-d from --
	at org.genesys2.server.service.filter.AppliedFiltersConverter.parseDate(AppliedFiltersConverter.java:362)
	at org.genesys2.server.service.filter.AppliedFiltersConverter.lambda$convertDateFilter$5(AppliedFiltersConverter.java:333)
	at java.lang.Iterable.forEach(Iterable.java:75)
java.lang.RuntimeException: Could not convert filters
	at org.genesys2.server.service.impl.FilterHandler$AppliedFilters.convert(FilterHandler.java:517)
	at org.genesys2.server.mvc.ExplorerController.viewFiltered(ExplorerController.java:240)
	at org.genesys2.server.mvc.ExplorerController$$FastClassBySpringCGLIB$$827bbdf0.invoke(<generated>)

There's an NPE

13:00:51,218 qtp2027961269-2490 ERROR o.g.s.m.UserControllerAdvice:103 - null on GET http://www.genesys-pgr.org/expl
java.lang.NullPointerException
	at org.genesys2.server.service.filter.AccessionFilter.buildQuery(AccessionFilter.java:286)
	at org.genesys2.server.service.filter.AccessionFilter.buildPredicate(AccessionFilter.java:116)

And this

Caused by: 
javax.servlet.ServletException: java.lang.IllegalStateException: Page needs a session and none is available
	at org.apache.jsp.WEB_002dINF.jsp.errors.error_jsp._jspService(error_jsp.java:235)
	at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
	at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:443)
	at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:386)
Edited by Matija Obreza